Skip to content

Fix Circular Dependency issues for New Arch Apps#15747

Merged
acoates-ms merged 12 commits intomainfrom
circulardependencyCheck
Mar 17, 2026
Merged

Fix Circular Dependency issues for New Arch Apps#15747
acoates-ms merged 12 commits intomainfrom
circulardependencyCheck

Conversation

@vineethkuttan
Copy link
Contributor

@vineethkuttan vineethkuttan commented Mar 9, 2026 •
edited
Loading

Description

Fixing Circular Dependency issues for New Arch Apps

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

Due to ongoing issues in microsoft/cppwinrt#950 , we added a temporary fix in #13338 to make the projects build with -m , i.e one concurrent process for building the RNW App, refer here

What

Inspired by this changes microsoft/winget-cli#5932 , I have defined CppWinRTGenerateWindowsMetadata to prevent the circular reference in calculating the value

Testing

Tested in playground

Changelog

Should this change be included in the release notes: yes

Circular dependency build issues for RNW Fabric App has been fixed

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link

github-actions bot commented Mar 10, 2026 •
edited
Loading

Performance Test Results

Branch: circulardependencyCheck
Commit: c6912e79
Time: 2026-03-11T06:53:52.052Z
Tests: 146/147 passed

✅ Passed

147 scenario(s) across 14 suite(s) — no regressions

SectionList

Scenario Mean Median StdDev Renders vs Baseline
SectionList mount 4.90ms 5.00ms ±0.57ms 1 +0.0%
SectionList unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
SectionList rerender 11.60ms 10.50ms ±2.88ms 2 +0.0%
SectionList with-3-sections-15-items 5.70ms 5.50ms ±1.34ms 1 +0.0%
SectionList with-5-sections-50-items 6.10ms 6.00ms ±1.20ms 1 +0.0%
SectionList with-10-sections-200-items 5.50ms 5.50ms ±0.53ms 1 +0.0%
SectionList with-20-sections-200-items 4.60ms 5.00ms ±1.65ms 1 +0.0%
SectionList with-section-separator 2.00ms 2.00ms ±0.47ms 1 +0.0%
SectionList with-item-separator 2.50ms 2.00ms ±0.97ms 1 +0.0%
SectionList with-header-footer 2.10ms 2.00ms ±0.32ms 1 +0.0%
SectionList with-section-footer 2.10ms 2.00ms ±0.57ms 1 +0.0%
SectionList with-sticky-section-headers 2.40ms 2.00ms ±1.26ms 1 +0.0%
SectionList with-empty-list 0.60ms 1.00ms ±0.52ms 1 +0.0%
SectionList with-50-sections-1000-items 1.80ms 2.00ms ±0.42ms 1 +0.0%

FlatList

Scenario Mean Median StdDev Renders vs Baseline
FlatList mount 4.10ms 4.00ms ±0.74ms 1 +0.0%
FlatList unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
FlatList rerender 9.50ms 9.00ms ±1.58ms 2 +0.0%
FlatList with-10-items 4.60ms 4.00ms ±1.26ms 1 +0.0%
FlatList with-100-items 4.70ms 5.00ms ±0.67ms 1 +0.0%
FlatList with-500-items 4.30ms 4.00ms ±0.67ms 1 +0.0%
FlatList horizontal 4.80ms 5.00ms ±1.75ms 1 +0.0%
FlatList with-separator 1.60ms 2.00ms ±0.52ms 1 +0.0%
FlatList with-header-footer 1.90ms 2.00ms ±1.20ms 1 +0.0%
FlatList with-empty-list 0.50ms 0.50ms ±0.53ms 1 +0.0%
FlatList with-get-item-layout 1.30ms 1.00ms ±0.48ms 1 +0.0%
FlatList inverted 1.90ms 1.50ms ±1.52ms 1 +0.0%
FlatList with-num-columns 2.80ms 3.00ms ±0.92ms 1 +0.0%
FlatList with-1000-items 4.50ms 4.00ms ±0.71ms 1 +0.0%

TouchableOpacity

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity mount 0.80ms 1.00ms ±0.42ms 1 +0.0%
TouchableOpacity unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableOpacity rerender 1.00ms 1.00ms ±0.67ms 2 +0.0%
TouchableOpacity custom-active-opacity 0.80ms 1.00ms ±0.42ms 1 +0.0%
TouchableOpacity disabled 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-all-handlers 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-hit-slop 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-delay 0.90ms 1.00ms ±0.88ms 1 +0.0%
TouchableOpacity nested 1.40ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity multiple-10 6.60ms 6.00ms ±1.76ms 1 +0.0%
TouchableOpacity multiple-50 28.93ms 29.00ms ±1.67ms 1 +0.0%
TouchableOpacity multiple-100 30.67ms 30.00ms ±3.68ms 1 +0.0%

ScrollView

Scenario Mean Median StdDev Renders vs Baseline
ScrollView mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
ScrollView unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ScrollView rerender 0.60ms 1.00ms ±0.52ms 2 +0.0%
ScrollView children-20 3.87ms 4.00ms ±0.99ms 1 +0.0%
ScrollView children-100 15.60ms 16.00ms ±1.64ms 1 +0.0%
ScrollView horizontal 4.00ms 4.00ms ±1.15ms 1 +0.0%
ScrollView sticky-headers 2.70ms 3.00ms ±1.06ms 1 +0.0%
ScrollView scroll-indicators 0.80ms 1.00ms ±0.42ms 1 +0.0%
ScrollView nested 1.30ms 1.00ms ±0.48ms 1 +0.0%
ScrollView content-container-style 0.70ms 1.00ms ±0.48ms 1 +0.0%
ScrollView children-500 19.67ms 19.00ms ±2.06ms 1 +0.0%

TouchableHighlight

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight mount 0.50ms 0.50ms ±0.53ms 1 +0.0%
TouchableHighlight unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
TouchableHighlight rerender 0.60ms 1.00ms ±0.52ms 2 +0.0%
TouchableHighlight custom-underlay-color 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight custom-active-opacity 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight with-all-handlers 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight with-hit-slop 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight nested-touchables 0.80ms 1.00ms ±0.42ms 1 +0.0%
TouchableHighlight multiple-touchables-10 2.60ms 3.00ms ±0.52ms 1 +0.0%
TouchableHighlight multiple-touchables-50 13.00ms 12.50ms ±1.56ms 1 +0.0%
TouchableHighlight multiple-touchables-100 22.70ms 22.50ms ±2.87ms 1 +0.0%

Pressable

Scenario Mean Median StdDev Renders vs Baseline
Pressable mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Pressable unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Pressable rerender 0.50ms 0.50ms ±0.53ms 2 +0.0%
Pressable with-all-handlers 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable with-style-function 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable disabled 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable with-hit-slop 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable nested 0.90ms 1.00ms ±1.20ms 1 +0.0%
Pressable multiple-10 3.13ms 3.00ms ±0.52ms 1 +0.0%
Pressable multiple-50 14.33ms 14.00ms ±1.23ms 1 +0.0%
Pressable multiple-100 16.00ms 12.00ms ±8.86ms 1 +0.0%

Modal

Scenario Mean Median StdDev Renders vs Baseline
Modal mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Modal unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Modal rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
Modal slide-animation 0.40ms 0.00ms ±0.52ms 1 +0.0%
Modal fade-animation 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal transparent 0.40ms 0.00ms ±0.52ms 1 +0.0%
Modal with-callbacks 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal rich-content 1.80ms 2.00ms ±0.42ms 1 +0.0%
Modal with-accessibility 0.40ms 0.00ms ±0.52ms 1 +0.0%

Image

Scenario Mean Median StdDev Renders vs Baseline
Image mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Image rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
Image with-resize-mode 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-border-radius 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image with-tint-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-blur-radius 0.00ms 0.00ms ±0.00ms 1 +0.0%
Image with-accessibility 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image multiple-10 0.93ms 1.00ms ±0.26ms 1 +0.0%
Image multiple-50 3.53ms 3.00ms ±1.19ms 1 +0.0%
Image multiple-100 8.87ms 8.00ms ±2.17ms 1 +0.0%

ActivityIndicator

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ActivityIndicator rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
ActivityIndicator size-large 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator size-small 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-color 0.00ms 0.00ms ±0.00ms 1 +0.0%
ActivityIndicator not-animating 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator with-accessibility 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator multiple-10 0.87ms 1.00ms ±0.35ms 1 +0.0%
ActivityIndicator multiple-50 3.87ms 4.00ms ±0.99ms 1 +0.0%
ActivityIndicator multiple-100 7.40ms 7.00ms ±1.18ms 1 +0.0%

Switch

Scenario Mean Median StdDev Renders vs Baseline
Switch mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Switch rerender 0.50ms 0.50ms ±0.53ms 2 +0.0%
Switch value-true 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch disabled 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch custom-colors 0.40ms 0.00ms ±0.52ms 1 +0.0%
Switch on-value-change 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch with-accessibility 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch multiple-10 2.00ms 2.00ms ±1.20ms 1 +0.0%
Switch multiple-50 9.20ms 9.00ms ±1.42ms 1 +0.0%
Switch multiple-100 17.27ms 16.00ms ±2.05ms 1 +0.0%

Button

Scenario Mean Median StdDev Renders vs Baseline
Button mount 0.70ms 1.00ms ±0.48ms 1 +0.0%
Button unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
Button rerender 1.00ms 1.00ms ±0.67ms 2 +0.0%
Button disabled 0.70ms 1.00ms ±0.48ms 1 +0.0%
Button with-color 0.50ms 0.50ms ±0.53ms 1 +0.0%
Button with-accessibility 0.70ms 1.00ms ±0.48ms 1 +0.0%
Button multiple-10 5.73ms 6.00ms ±0.96ms 1 +0.0%
Button multiple-50 22.40ms 27.00ms ±7.79ms 1 +0.0%
Button multiple-100 19.13ms 19.00ms ±2.13ms 1 +0.0%

TextInput

Scenario Mean Median StdDev Renders vs Baseline
TextInput mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
TextInput rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
TextInput multiline 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput with-value 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput styled 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput multiple-100 7.00ms 7.00ms ±1.13ms 1 +0.0%

View

Scenario Mean Median StdDev Renders vs Baseline
View mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
View unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
View rerender 0.40ms 0.00ms ±0.52ms 2 +0.0%
View nested-50 3.47ms 3.00ms ±0.92ms 1 +0.0%
View nested-100 7.33ms 7.00ms ±1.18ms 1 +0.0%
View shadow 0.00ms 0.00ms ±0.00ms 1 +0.0%
View border-radius 0.10ms 0.00ms ±0.32ms 1 +0.0%
View nested-500 16.20ms 10.00ms ±11.48ms 1 +0.0%

Text

Scenario Mean Median StdDev Renders vs Baseline
Text mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Text rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
Text long-1000 0.10ms 0.00ms ±0.32ms 1 +0.0%
Text nested 0.30ms 0.00ms ±0.48ms 1 +0.0%
Text styled 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text multiple-100 7.47ms 7.00ms ±1.13ms 1 +0.0%

@microsoft microsoft deleted a comment from azure-pipelines bot Mar 10, 2026
@microsoft microsoft deleted a comment from azure-pipelines bot Mar 10, 2026
@vineethkuttan vineethkuttan marked this pull request as ready for review March 16, 2026 04:42
@vineethkuttan vineethkuttan requested review from a team as code owners March 16, 2026 04:42
@vineethkuttan vineethkuttan changed the title [DRAFT] Circular dependency check Fixi Circular Dependency issues for New Arch Apps Mar 16, 2026
acoates-ms
acoates-ms reviewed Mar 16, 2026
View reviewed changes
@acoates-ms acoates-ms mentioned this pull request Mar 16, 2026
Merged
@vmoroz vmoroz changed the title Fixi Circular Dependency issues for New Arch Apps Fix Circular Dependency issues for New Arch Apps Mar 16, 2026
@microsoft microsoft deleted a comment from azure-pipelines bot Mar 17, 2026
@vineethkuttan
Copy link
Contributor Author

vineethkuttan commented Mar 17, 2026

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Mar 17, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Mar 17, 2026
iamAbhi-916
iamAbhi-916 approved these changes Mar 17, 2026
View reviewed changes
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acoates-ms acoates-ms merged commit d02a7c6 into main Mar 17, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms acoates-ms left review comments

@iamAbhi-916 iamAbhi-916 iamAbhi-916 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New arch app first builds sometimes fail with circular dependency error MSB4006

3 participants

@vineethkuttan @acoates-ms @iamAbhi-916